[boulanger]

mcritdamage function in skills is bad, it always multiplies to max magical critical damage value when MCRITDAMAGE used in skills, NO MATTER WHAT VALUE You put to mcritdamage!! (x20)

for exemple, here is a character, NO SKILL < no active, no passive> NO BUFFS .whoami (x5 crit damage, wich is also wrong, default is x2 in god )



after i equip an eternal robe set (passive skill 13090 lvl 4).
Note, character has only the set skills, NO BUFF< nothing else



skill formula from database:

<skill id="13090" levels="4" name="Эффект Комплекта - Магические Доспехи Айдиоса 2 шт. (маг.)">
		<!--	ИНТ +3, ДУХ -1, Скор. Маг. +3%.
				ИНТ +3, ДУХ -1, Скор. Маг. +3%, MP +228, сопротивление удержанию +10.
				ИНТ +3, ДУХ -1, Скор. Маг. +3%, MP +228, сопротивление удержанию +10, Маг. Атк. +256., Сила Маг. Крит. Атк. +297.
				ИНТ +3, ДУХ -1, Скор. Маг. +15%, Маг. Атк. +15%, MP +228, сопротивление удержанию +10, Маг. Атк. +256., сила Маг. Крит. Атк. +297, шанс Маг. Крит. Атк. +30, сопротивление стихиям +15.
		-->
		<table name="#mAtkSpd">1.03 1.03 1.03 1.15</table>
		<table name="#mAtk">1 1 1 1.15</table>
		<table name="#mAtkAdd">0 0 256 256</table>
		<table name="#maxMp">0 228 228 228</table>
		<table name="#mCritDamage">0 0 297 297</table>
		<table name="#mCritRate">0 0 0 30</table>
		<table name="#rootResist">0 10 10 10</table>
		<table name="#defenceFire">0 0 0 15</table>
		<table name="#defenceWater">0 0 0 15</table>
		<table name="#defenceWind">0 0 0 15</table>
		<table name="#defenceEarth">0 0 0 15</table>
		<set name="magicLevel" value="1"/>
		<set name="icon" value="icon.skill13063"/>
		<set name="target" value="TARGET_SELF"/>
		<set name="skillType" value="BUFF"/>
		<set name="operateType" value="OP_PASSIVE"/>
		<for>
			<add order="0x10" stat="INT" value="3"/>
			<sub order="0x10" stat="MEN" value="1"/>
			<mul order="0x30" stat="mAtk" value="#mAtk"/>
			<add order="0x40" stat="mAtk" value="#mAtkAdd"/>
			<mul order="0x30" stat="mAtkSpd" value="#mAtkSpd"/>
			<add order="0x40" stat="maxMp" value="#maxMp"/>
			<add order="0x40" stat="baseMCritRate" value="#mCritRate"/>
			<add order="0x40" stat="mCritDamage" value="#mCritDamage"/>
			<add order="0x40" stat="rootResist" value="#rootResist"/>
			<add order="0x40" stat="defenceFire" value="#defenceFire"/>
			<add order="0x40" stat="defenceWater" value="#defenceWater"/>
			<add order="0x40" stat="defenceWind" value="#defenceWind"/>
			<add order="0x40" stat="defenceEarth" value="#defenceEarth"/>
		</for>
	</skill>

look in skill , mcritdamage added is value 297, but result is x20 magical critical damage!!! multiplies 20 times the damage of character, instead of +297, ADDING

this happens, NO MATTER WHAT VALUE IS USED< any value used with mcritdamage function, result x20 crit damage.

<table name="#mCritDamage">0 0 297 297</table>
<add order="0x40" stat="mCritDamage" value="#mCritDamage"/>


result , in game .whoami



also, in god all characters have 2x critical damage default, now i log in game with any character, .whoami and i see x5 critical damage from start.

so now there is no static magical critical damage in your pack, like static physical critical damage for fighter and mCritDamage BUGGS the characters magical critical damage, boosting it to max cap x20!

mcritdamage is wrongly made,


--- here is another project, i had before for 6 months and mcrit damage static was working fine, and used instead of mcritdamage on the entire project mcatkstatic, and in game all was fine, no more x20 crit damage. i know u can limit in formulas to reduce magical critical damage, in config, but it s not the same, because in the end, characters still wont have BONUS mcritdamage as they should, exact value, like physical crit damage for fighters and you risk reduceing too much the critical damage, either top geared chars have too much damage, or lower geared chars do less damage with critical magic then normal damage.

this is the stats.java (gameserver/stats/stats.java)

https://code.google.com/p/l2jeuropa/...ats/Stats.java

MCRITICAL_DAMAGE_STATIC("mCAtkStatic"),

[iqman]

transfered to CORE, he'll take a look if it's right.

[iqman]

Fixed .